Feature species - more adjoint parts by TobiKattmann · Pull Request #1461 · su2code/SU2

TobiKattmann · 2021-12-02T17:09:58Z

Hi,

Some necessary changes for the species transport solver to work nicely with the Discrete adjoint solver. So it is the same structure that was Introduced for CFlowOutput but now it is CAdjFlowOutput.

generalize turb+species output for Comp/Inc/NEMO away into a parent class to avoid duplication (Done)
Make More OF available such that one can actually use the DA solver
Add a Gradient validation + Optimization FADO template plus add DA regression tests (or tutorials 🤔 I think I will make a tutorial thing for this)
Some smaller fixes to the previous PR

Related Work

directly following #1388 where the majority of adjoint work for the species solver was already done

PR Checklist

I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
My contribution is commented and consistent with SU2 style.
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

Generalization of the adjont output necessary

TobiKattmann · 2021-12-02T23:01:01Z

generalize turb+species output for Comp/Inc/NEMO away into a parent class to avoid duplication

Actually I just noticed there is no CAdjNEMOOutput or similar. Not sure @WallyMaier , but is the NEMO-tribe not doing in adjoints?

SU2_CFD/src/output/CAdjFlowOutput.cpp

WallyMaier · 2021-12-03T02:35:21Z

@TobiKattmann I am actually developing the adjoint stuff for nemo right now! Though there are some recording issues....

TobiKattmann · 2021-12-03T16:53:48Z

@TobiKattmann I am actually developing the adjoint stuff for nemo right now! Though there are some recording issues....

Ok @WallyMaier if this PR gets merged then there will be a CAdjFlowOutput class between COutput and e.g. CNEMOAdjOutput (or to be more precise: it is for inc and comp and it should be done for NEMO as well). That class provides output for the turbulence solvers and the separate species solver. So looking at CAdjFLowIncOutput then will show the methods called and that should be a straight forward change in `CNEMOAdjOutput

SU2_CFD/src/output/CAdjFlowOutput.cpp

TobiKattmann

Really nice 👍 puts this logic into one place and avoids a bunch of work for future changes

Common/include/option_structure.hpp

TobiKattmann · 2021-12-06T13:51:26Z

I will add surface avg species_0 as another Objective function (Edit: done in 31d7a95) but that would be it from my side concerning this PR

Only Species_0 because one can of course always shift the species functions around. In case more than one avg surf Spec is needed at once, the one has to add it manually

TobiKattmann · 2021-12-06T16:16:37Z

So the merging process would of course be:

merge tutorials (+website)
revert regression.yml changes
merge this PR

... in case the people are happy with it

SU2_CFD/include/solvers/CScalarSolver.inl

SU2_CFD/src/solvers/CSpeciesSolver.cpp

SU2_CFD/src/solvers/CTurbSolver.cpp

Co-authored-by: Pedro Gomes <pcarruscag@gmail.com>

Common/include/option_structure.hpp

SU2_CFD/src/solvers/CHeatSolver.cpp

Note that the AddHistoryOutput lines are read by the update_historyMap.py script. And if there are line breaks there are information missing for that script. Using // clang-format off/on can prevent this accidentally breaking.

SU2_CFD/src/output/CAdjFlowOutput.cpp

SU2_CFD/src/output/CFlowOutput.cpp

TestCases/tutorials.py

TestCases/parallel_regression.py

SU2_CFD/src/solvers/CEulerSolver.cpp

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

…ecies

SU2_CFD/src/solvers/CDiscAdjSolver.cpp

TobiKattmann added 2 commits December 2, 2021 18:03

Adding RMS_ADJ_Species output and variance OF.

932de5d

Generalization of the adjont output necessary

Merge remote-tracking branch 'origin/develop' into feature_species

aa1c48b

pr-triage bot added the PR: unreviewed label Dec 2, 2021

TobiKattmann marked this pull request as draft December 2, 2021 17:10

TobiKattmann changed the title ~~Feature species - more adjoint parts~~ [WIP] Feature species - more adjoint parts Dec 2, 2021

pr-triage bot added PR: draft and removed PR: unreviewed labels Dec 2, 2021

TobiKattmann added changelog:feature and removed PR: draft labels Dec 2, 2021

Add DA species regression test

d899875

This was referenced Dec 2, 2021

Feature species adjoinit su2code/TestCases#86

Closed

Feature species adjiont su2code/TestCases#87

Closed

Introduce MVP CAdjFlowOutput.

402a690

pr-triage bot added the PR: draft label Dec 2, 2021

TobiKattmann added 3 commits December 3, 2021 01:06

Create history adj scalar output

0f0ed14

Create volume adj scalar output

35d047b

Fix BGS output by wrapping in multizone conditional

f1fbd92

TobiKattmann commented Dec 3, 2021

View reviewed changes

SU2_CFD/src/output/CAdjFlowOutput.cpp Outdated Show resolved Hide resolved

One more multizone BGS fix

b9152fb

pcarruscag reviewed Dec 3, 2021

View reviewed changes

SU2_CFD/src/output/CAdjFlowOutput.cpp Outdated Show resolved Hide resolved

SU2_CFD/src/output/CAdjFlowOutput.cpp Outdated Show resolved Hide resolved

Make member vars const by using initializer list.

c2e652a

TobiKattmann mentioned this pull request Dec 4, 2021

Species transport theory + tutorials su2code/su2code.github.io#64

Merged

pcarruscag added 2 commits December 4, 2021 14:08

turb model family

5b3f7d3

apply to other places

6949b66

TobiKattmann commented Dec 4, 2021

View reviewed changes

Common/include/option_structure.hpp Show resolved Hide resolved

TobiKattmann added 2 commits December 5, 2021 19:11

Fix bug where species MUSCL and limiter were not working at all.

4899ed6

Add inital value for muscl and limiter to fix builds.

6d1d59b

TobiKattmann marked this pull request as ready for review December 6, 2021 13:50

pr-triage bot added PR: unreviewed and removed PR: draft labels Dec 6, 2021

Add Avg surf Species_0 OF.

31d7a95

Only Species_0 because one can of course always shift the species functions around. In case more than one avg surf Spec is needed at once, the one has to add it manually

pcarruscag reviewed Dec 7, 2021

View reviewed changes

TobiKattmann and others added 4 commits December 8, 2021 11:01

Revert implicit class data switch.

54a0c69

Use Muscl and limiter from GlobalParams for ScalarSolver

5fc376e

Additional line break.

04533a5

Co-authored-by: Pedro Gomes <pcarruscag@gmail.com>

Add setGlobalParams in all Preprocessing routines

e93f5c4

pcarruscag reviewed Dec 8, 2021

View reviewed changes

Common/include/option_structure.hpp Show resolved Hide resolved

TobiKattmann commented Dec 8, 2021

View reviewed changes

SU2_CFD/src/solvers/CHeatSolver.cpp Show resolved Hide resolved

TobiKattmann added 3 commits December 8, 2021 12:27

Revert unnecessary changes

740f19e

Run update_historyMap.py

a2cb413

pcarruscag approved these changes Dec 9, 2021

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Dec 9, 2021

Better english in comments

e10bdf9

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

pr-triage bot added PR: unreviewed and removed PR: reviewed-approved labels Dec 9, 2021

TobiKattmann added 2 commits December 9, 2021 15:06

Remove set globalParam in Preproc from Flow Solvers.

57a87e5

Merge remote-tracking branch 'origin/feature_species' into feature_sp…

fe84c72

…ecies

pcarruscag reviewed Dec 9, 2021

View reviewed changes

SU2_CFD/src/solvers/CDiscAdjSolver.cpp Show resolved Hide resolved

Revert indermediate tutorial branch change for reg tests.

df093ba

TobiKattmann merged commit 1567259 into develop Dec 10, 2021

TobiKattmann deleted the feature_species branch December 10, 2021 10:47

pr-triage bot added PR: merged and removed PR: unreviewed labels Dec 10, 2021

Conversation

TobiKattmann commented Dec 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Work

PR Checklist

Uh oh!

TobiKattmann commented Dec 2, 2021

Uh oh!

Uh oh!

WallyMaier commented Dec 3, 2021

Uh oh!

TobiKattmann commented Dec 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TobiKattmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TobiKattmann commented Dec 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TobiKattmann commented Dec 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TobiKattmann commented Dec 2, 2021 •

edited

Loading

TobiKattmann commented Dec 3, 2021 •

edited

Loading

TobiKattmann commented Dec 6, 2021 •

edited

Loading

TobiKattmann commented Dec 6, 2021 •

edited

Loading